Closed slorber closed 2 years ago
Size Change: 0 B
Total Size: 554 kB
Name | Link |
---|---|
Latest commit | 526eef3e438028f676553f254e8cf1c1594d2676 |
Latest deploy log | https://app.netlify.com/sites/infima/deploys/62b427e90fbba80008870c57 |
Deploy Preview | https://deploy-preview-263--infima.netlify.app |
Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site settings.
Note there's still one case where we display the logo for dark mode on a light background:
Would using another src work?
Would using another src work?
No because then it's the other theme that would be broken đ¤Ē
We'd need something akin to <ThemedImage>
but just in static markup: we don't have the concept of themed image in Infima directly. Maybe we should đ¤ˇââī¸
If you find a solution without polluting the documentation with useless technical code, why not. I'd rather not invest too much time on this little thing.
Ah, didn't realize the footer is themed.
Fixes https://github.com/facebookincubator/infima/issues/239
Note there's still one case where we display the logo for dark mode on a light background:
I think it's better to not fix it because the documented markup is static (but the theme/backgroundColor is dynamic): fixing this would likely create noise in our doc for little ROI