search

facebookincubator / infima

A UI framework that provides websites with the minimal CSS and JS needed to get started with building a modern responsive beautiful website
https://infima.dev
MIT License
408 stars 55 forks source link

Code sample for "active" Button include "outline" classes #273

Closed jodyheavener closed 1 year ago

jodyheavener commented 2 years ago

Small thing. I was looking through the Button component variations and noticed that the "active" style's code samples include classes present in the "outline" style. For example:

<button class="button button--outline button--active button--primary">
  Primary
</button>

Removing the button--outline class appears to retain the active style, any reason it should be left in there?

sanketmunot commented 1 year ago

Created a PR #279 Can check for build here -> https://deploy-preview-279--infima.netlify.app/docs/components/button#active

Thanks !