facebookincubator / infima

A UI framework that provides websites with the minimal CSS and JS needed to get started with building a modern responsive beautiful website
https://infima.dev
MIT License
408 stars 55 forks source link

docs: remove extra useless button--outline class from button active #279

Closed sanketmunot closed 1 year ago

sanketmunot commented 1 year ago

Why this PR: Should fix #273

What is the issue: We are using button--outline class in documentation for button active, which is ideally not required.

As part of this PR, removed button--outline class from Docs & local Infima

Before change: image

After change: image

facebook-github-bot commented 1 year ago

Hi @sanketmunot!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

netlify[bot] commented 1 year ago

Deploy Preview for infima ready!

Built without sensitive environment variables

Name Link
Latest commit aff10d2beb5d50554f5e444d9ffc1a3c34d4a479
Latest deploy log https://app.netlify.com/sites/infima/deploys/638f9162ce612100092dc5a8
Deploy Preview https://deploy-preview-279--infima.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

facebook-github-bot commented 1 year ago

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

slorber commented 1 year ago

Thanks 👍