facebookincubator / infima

A UI framework that provides websites with the minimal CSS and JS needed to get started with building a modern responsive beautiful website
https://infima.dev
MIT License
408 stars 55 forks source link

Update typography.pcss #290

Open homotechsual opened 1 year ago

homotechsual commented 1 year ago

Add default underline to links for better non-colour dependant compliance with WCAG 1.4.1 (rule id: link-in-text-block)

netlify[bot] commented 1 year ago

Deploy Preview for infima ready!

Built without sensitive environment variables

Name Link
Latest commit 09a99e2e6254418accbc4973c471c81bea5cb617
Latest deploy log https://app.netlify.com/sites/infima/deploys/64f888fabf38940008523603
Deploy Preview https://deploy-preview-290--infima.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Josh-Cena commented 7 months ago

I think this can be opt-in, but I doubt most users are going to welcome this change.

hichemfantar commented 4 months ago

I agree it should be off by default. Users can easily override the css variable.

It doesn't look good in the navbar

image