search

facebookincubator / infima

A UI framework that provides websites with the minimal CSS and JS needed to get started with building a modern responsive beautiful website
https://infima.dev
MIT License
408 stars 55 forks source link

Fix: pagination-nav height bug on Safari #291

Closed rbatsenko closed 10 months ago

rbatsenko commented 1 year ago

Hey team,

There seems to be an issue with pagination nav items in Docusaurus on Safari, screenshot attached. I first noticed it on mobile (iPhone), but turns out it was Safari-related, no matter the screen size.

Removing height: 100% seem to fix it and do no harm on other browsers (at least on Chrome) 🙂

Screenshot 2023-09-29 at 10 22 34
facebook-github-bot commented 1 year ago

Hi @rbatsenko!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

netlify[bot] commented 1 year ago

Deploy Preview for infima ready!

Built without sensitive environment variables

Name Link
Latest commit 5b22d4075b7a092374c062adcda298828de48d59
Latest deploy log https://app.netlify.com/sites/infima/deploys/651693e36725860008d6b9dc
Deploy Preview https://deploy-preview-291--infima.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

rbatsenko commented 1 year ago

Not sure why the property is still there on Netlify deployed preview 🤔

facebook-github-bot commented 1 year ago

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

slorber commented 10 months ago

Going to close this for now because we need to see the problem in practice. Please create a repro.