facebookincubator / infima

A UI framework that provides websites with the minimal CSS and JS needed to get started with building a modern responsive beautiful website
https://infima.dev
MIT License
408 stars 55 forks source link

Document text utility classes. #304

Closed homotechsual closed 6 months ago

netlify[bot] commented 6 months ago

Deploy Preview for infima ready!

Built without sensitive environment variables

Name Link
Latest commit 78600f22d17080941921596bf959b66a336612da
Latest deploy log https://app.netlify.com/sites/infima/deploys/660d36f6621aa700089960b2
Deploy Preview https://deploy-preview-304--infima.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

slorber commented 6 months ago

LGTM thanks 👍

slorber commented 6 months ago

Note: it's not super important to invest time in document those because sooner or later I'll merge back Infima into theme classic and cleanup everything we don't use. Infima will become an internal implementation detail rather than a public API recommended to use.

homotechsual commented 6 months ago

Note: it's not super important to invest time in document those because sooner or later I'll merge back Infima into theme classic and cleanup everything we don't use. Infima will become an internal implementation detail rather than a public API recommended to use.

When that happens would we want to move documentation on the theme framework classes to the Docusaurus documentation anyway to make it easier for folks writing custom components/plugins to reuse theme-classic provided classes if they wish?

slorber commented 6 months ago

to make it easier for folks writing custom components/plugins to reuse theme-classic provided classes

Actually I want to avoid that. If we introduce a theme-classic-tailwind later those Infima classes won't exist. Plugins need to be independent, and one plugin should rather not use classes coming from another.

Plugins like search etc should rather use CSS Modules instead of Infima