search

facebookincubator / katran

A high performance layer 4 load balancer
GNU General Public License v2.0
4.75k stars 504 forks source link

Fixing missing "/" in example_grpc/build_grpc_client.sh #187

Closed balisong77 closed 1 year ago

balisong77 commented 1 year ago

There is a missing "/" in example_grpc/build_grpc_client.shL65, which will lead to a building failure.

facebook-github-bot commented 1 year ago

Hi @balisong77!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

avasylev commented 1 year ago

This has been fixed in https://github.com/facebookincubator/katran/commit/b24ac069cc02824b4320a1429634608cf4f93ffa