search

facebookincubator / reindeer

Reindeer is a tool to transform Rust Cargo dependencies into generated Buck build rules
MIT License
184 stars 30 forks source link

Fix typo in README #1

Closed davemachado closed 4 years ago

davemachado commented 4 years ago

Yay Rust!

facebook-github-bot commented 4 years ago

Hi @davemachado!

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file.

In order for us to review and merge your code, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

davemachado commented 4 years ago

Looks like a missing file is causing Travis to fail:

IOError: [Errno 2] No such file or directory: u'fbcode_builder_config.py'

+docker_context_dir=

The command "./build/fbcode_builder/travis_docker_build.sh" exited with 1.
facebook-github-bot commented 4 years ago

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

jsgf commented 4 years ago

Thanks for the fix!

I haven't publicized this project must yet because it's still a bit rough. I definitely need to work out how CI should work and fill out the documentation a bit.

facebook-github-bot commented 4 years ago

@jsgf merged this pull request in facebookincubator/reindeer@194ffbc24087d0b721cdfa22da95eaaa32c20bf4.