search

facebookincubator / reindeer

Reindeer is a tool to transform Rust Cargo dependencies into generated Buck build rules
MIT License
179 stars 28 forks source link

Remove pointless comparison #26

Closed Jake-Shadle closed 1 year ago

Jake-Shadle commented 1 year ago

When parsing the cargo sources the code was comparing the rev specified by the user to the full sha-1 commit hash that cargo locked the git repository to. This would cause reindeer buckify to fail if the user specified a short (7+) hash, a common practice. This check is really rather pointless, as the commit hash is the only thing that truly matters, and if the user did in fact specify an ambiguous/incorrect hash, short or otherwise, cargo would fail to get the correct full sha-1 commit hash anyways, something that reindeer itself need not handle, nor care about, at least in this context.

facebook-github-bot commented 1 year ago

@shayne-fletcher has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

facebook-github-bot commented 1 year ago

@shayne-fletcher merged this pull request in facebookincubator/reindeer@d4cf6526b4239efb4a7388154e19bbb403e52f67.