facebookincubator / velox

A C++ vectorized database acceleration library aimed to optimizing query engines and data processing systems.
https://velox-lib.io/
Apache License 2.0
3.28k stars 1.09k forks source link

from_iso8601_date Presto function should accept more formats #10058

Open mbasmanova opened 1 month ago

mbasmanova commented 1 month ago

Bug description

Presto Java uses Joda which accepts formats described by the following syntax:

       date-element      = std-date-element | ord-date-element | week-date-element
       std-date-element  = yyyy ['-' MM ['-' dd]]
       ord-date-element  = yyyy ['-' DDD]
       week-date-element = xxxx '-W' ww ['-' e]

Velox supports only std-date-element, but not ord-date-element or week-date-element. See https://www.joda.org/joda-time/field.html for the defintions of these.

presto:di> select from_iso8601_date('2024-123'); -- ord-date-element
   _col0
------------
 2024-05-02
(1 row)

presto:di> select from_iso8601_date('2003-W01-1'); -- week-date-element
   _col0
------------
 2002-12-30
(1 row)

CC: @pedroerp @amitkdutta @svm1

System information

n/a

Relevant logs

No response

mbasmanova commented 1 month ago

CC: @kgpai @kagamiori