search

facebookincubator / velox

A composable and fully extensible C++ execution engine library for data management systems.
https://velox-lib.io/
Apache License 2.0
3.52k stars 1.15k forks source link

Make sure entire code base is properly formatted #10240

Open assignUser opened 4 months ago

assignUser commented 4 months ago

While testing the new format I noticed that there are A LOT of files that are not correctly formatted but didn't show up because we only look at touched files. You can repro this by running ./scripts/check.py format tree --fix velox and check the changed files in git.

We should probably apply formatting across everything, merge that as a standalone commit and than create a git blame revs ignore file to avoid that commit showing up everywhere when people git blame. @kgpai @pedroerp @mbasmanova ?

Originally posted by @assignUser in https://github.com/facebookincubator/velox/issues/9948#issuecomment-2161795278

pedroerp commented 4 months ago

Sounds reasonable to me. Not sure how we ended up in this situation though; shouldn't CI check for format on everything new PRs are touching?

assignUser commented 4 months ago

There was a recent update to the clang-format file that probably covers most of what I saw? https://github.com/facebookincubator/velox/commit/955c071593c410cfe559ba3f51f563af4bad1195

pedroerp commented 4 months ago

Cc: @kevinwilfong

majetideepak commented 3 months ago

This is still not done.