search

facebookincubator / velox

A composable and fully extensible C++ execution engine library for data management systems.
https://velox-lib.io/
Apache License 2.0
3.53k stars 1.16k forks source link

Add lt, lte, gt, gte, neq, between for UUID type #10584

Open aditi-pandit opened 4 months ago

aditi-pandit commented 4 months ago

Description

Presto UUID type supports neq, lt, lte, gt, gte, between operations UUIDOperators

This allows more flexible use in SQL.

The lack of these operators causes exceptions today https://github.com/prestodb/presto/pull/23301/files#r1693434020

Since we support equality on UUID, it seems strange not to support the rest of these operations.

aditi-pandit commented 4 months ago

@mbasmanova : Any particular reason we don't support these ? Don't think this has the logical type comparison issue as Timestamp with Timezone.

BryanCutler commented 4 months ago

Hi @aditi-pandit I'll work on this one

mbasmanova commented 3 months ago

@aditi-pandit No particular reason. Let's add missing functionality.

@BryanCutler Thank you for offering to work on this.

mbasmanova commented 3 months ago

CC: @amitkdutta

BryanCutler commented 3 months ago

Just a quick update - I have the basic implementation done for comparisons, working on adding tests and will put up a PR soon.