search

facebookincubator / velox

A composable and fully extensible C++ execution engine library for data management systems.
https://velox-lib.io/
Apache License 2.0
3.5k stars 1.15k forks source link

PARQUET-686: Do not return min/max for the wrong order #10853

Open zml1206 opened 2 months ago

zml1206 commented 2 months ago

Bug description

Reference: PARQUET-686 https://github.com/apache/parquet-java/pull/367

System information

Velox System Info v0.0.2 Commit: dfa3710eb0c64ac7af4dbfc3b507e3e55cba2635 CMake Version: 3.30.2 System: Darwin-23.5.0 Arch: x86_64 C++ Compiler: /Library/Developer/CommandLineTools/usr/bin/c++ C++ Compiler Version: 15.0.0.15000309 C Compiler: /Library/Developer/CommandLineTools/usr/bin/cc C Compiler Version: 15.0.0.15000309 CMake Prefix Path: /Library/Developer/CommandLineTools/SDKs/MacOSX14.4.sdk/usr;/usr/local;/usr;/;/usr/local/Cellar/cmake/3.30.2;/usr/local;/usr/X11R6;/usr/pkg;/opt;/sw;/opt/local

Relevant logs

No response

zml1206 commented 2 months ago

Can we just give up using columnChunkStats.max and columnChunkStats.min to get min/max? After all, these two indicators were deprecated long ago. @majetideepak thank you.