facebookincubator / velox

A composable and fully extensible C++ execution engine library for data management systems.
https://velox-lib.io/
Apache License 2.0
3.52k stars 1.15k forks source link

laplace_cdf: Presto throws while Velox returns non-NULL #10974

Open kagamiori opened 2 months ago

kagamiori commented 2 months ago

Description

Query: select laplace_cdf(1, c0, 0.3) from (values nan()) t(c0); Presto-0.289: Throws an exception "(INVALID_FUNCTION_ARGUMENT) laplaceCdf Function: scale must be greater than 0" Velox: Returns NaN

Error Reproduction

No response

Relevant logs

No response

Yuhta commented 2 months ago

Since NaN is defined to be > 0, the error message from Java is obviously wrong