search

facebookincubator / velox

A composable and fully extensible C++ execution engine library for data management systems.
https://velox-lib.io/
Apache License 2.0
3.54k stars 1.17k forks source link

test: Add Crc32Benchmark #11545

Open yingsu00 opened 1 week ago

yingsu00 commented 1 week ago

This commit adds a benchmark for the crc32 performance measurements on different platforms.

netlify[bot] commented 1 week ago

Deploy Preview for meta-velox ready!

Name Link
Latest commit 9bdd673762f505e00164877f0ae5dce697bb4c6a
Latest deploy log https://app.netlify.com/sites/meta-velox/deploys/67467f0b166bd5000808a087
Deploy Preview https://deploy-preview-11545--meta-velox.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

facebook-github-bot commented 1 week ago

@Yuhta has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

aditi-pandit commented 1 week ago

@yingsu00 : Do you have any early results ?

assignUser commented 1 week ago

@pedro should the type of this be test or misc? I think test as I count fuzzers and benchmarks related to that or do you want that to explicitly only be for adding/modifying tests? It should imo not be feat as that equals a bump in version number that's not warranted for a test/util imo?

yingsu00 commented 1 week ago

@pedro should the type of this be test or misc? I think test as I count fuzzers and benchmarks related to that or do you want that to explicitly only be for adding/modifying tests? It should imo not be feat as that equals a bump in version number that's not warranted for a test/util imo?

Hi @assignUser good catch! I changed it to test.