search

facebookincubator / velox

A composable and fully extensible C++ execution engine library for data management systems.
https://velox-lib.io/
Apache License 2.0
3.53k stars 1.16k forks source link

feat: Support comparison for ipprefix [3/n] #11546

Open yuandagits opened 1 week ago

yuandagits commented 1 week ago

Summary: We need to support comparison for IPPrefix, which has underlying type of RowVector<HUGEINT, TINYINT>.

Since the first 16 bytes of IPPrefix is pretty much the same as IPAddress, we can just convert the underlying type of IPPrefix to RowVector<IPADDRESS, TINYINT>. Since IPADDRESS already has its custom comparison defined, and rowVector by default compares left to right, this takes of comparison for us for free.

Differential Revision: D65521072

facebook-github-bot commented 1 week ago

This pull request was exported from Phabricator. Differential Revision: D65521072

netlify[bot] commented 1 week ago

Deploy Preview for meta-velox canceled.

Name Link
Latest commit a24558c0e1057e014b7a0ca1f9b7e11b84f4dfd2
Latest deploy log https://app.netlify.com/sites/meta-velox/deploys/6736acff5aa4b600084ee40d
facebook-github-bot commented 1 week ago

This pull request was exported from Phabricator. Differential Revision: D65521072