facebookincubator / velox

A composable and fully extensible C++ execution engine library for data management systems.
https://velox-lib.io/
Apache License 2.0
3.53k stars 1.16k forks source link

fix: ExchangeBenchmark "Named vector serde 'Presto' is not registered" #11548

Closed yingsu00 closed 1 week ago

yingsu00 commented 1 week ago

https://github.com/facebookincubator/velox/pull/11445 introduced named vector SerDe registration. ExchangeBenchmark broke after that because it didn't register the kPresto Serde. This commit fixes it by registering it in the main() function.

Error code before:

E20241114 20:40:54.505862 3012487 Exceptions.h:66] Line: /Users/yingsu/repo/velox5/velox/velox/vector/VectorStream.cpp:176, Function:getNamedVectorSerde, Expression: it != namedSerdeMap.end() Named vector serde 'Presto' is not registered., Source: RUNTIME, ErrorCode: INVALID_STATE
libc++abi: terminating due to uncaught exception of type facebook::velox::VeloxRuntimeError: Exception: VeloxRuntimeError
Error Source: RUNTIME
Error Code: INVALID_STATE
Reason: Named vector serde 'Presto' is not registered.
Retriable: False
Expression: it != namedSerdeMap.end()
Function: getNamedVectorSerde
File: /Users/yingsu/repo/velox5/velox/velox/vector/VectorStream.cpp
Line: 176
netlify[bot] commented 1 week ago

Deploy Preview for meta-velox canceled.

Name Link
Latest commit 4920947253d780075e0c185c8a9762eaf0b179ab
Latest deploy log https://app.netlify.com/sites/meta-velox/deploys/6736d1928d96a1000853d77a
facebook-github-bot commented 1 week ago

@Yuhta has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

facebook-github-bot commented 1 week ago

@Yuhta merged this pull request in facebookincubator/velox@c21020c5a169e07ade866274e5cedd757973b708.