search

facebookincubator / velox

A composable and fully extensible C++ execution engine library for data management systems.
https://velox-lib.io/
Apache License 2.0
3.53k stars 1.16k forks source link

fix: Make width_bucket() behave like in Presto Java. #11557

Closed spershin closed 2 days ago

spershin commented 1 week ago

Summary: Presto Java treats null elements in the input array vector as zeroes, ignoring null flag. This is not entirely correct, but at least consistent. Velox currently just reads what value is in the element, ignoring null flag and is inconsistent as the memory is not necessarily zeroed.

Differential Revision: D66043501

facebook-github-bot commented 1 week ago

This pull request was exported from Phabricator. Differential Revision: D66043501

netlify[bot] commented 1 week ago

Deploy Preview for meta-velox canceled.

Name Link
Latest commit b6b77b2e74f50ec68c9b50ce0b19dac97665f6c2
Latest deploy log https://app.netlify.com/sites/meta-velox/deploys/6737f05d75ef970008e64b0d