search

facebookincubator / velox

A composable and fully extensible C++ execution engine library for data management systems.
https://velox-lib.io/
Apache License 2.0
3.54k stars 1.17k forks source link

feat: Specifiy target tracing driver IDs #11560

Closed duanmeng closed 2 days ago

duanmeng commented 1 week ago

Add a driver_ids flag to pass a comma-separated list of driver IDs string to specify the target driver ID list for replay. The replaying operator uses its driver instance ID as the list index to get the traced driver ID for replay.

Extract all driver IDs by listing the number of sub-directors under the trace directory and replay them all if driver_ids is empty.

Parts of #9668

netlify[bot] commented 1 week ago

Deploy Preview for meta-velox canceled.

Name Link
Latest commit c434cf32b785b8c8bed645772d91c742fc0b846b
Latest deploy log https://app.netlify.com/sites/meta-velox/deploys/67441fdb47475d0008ba7ad6
facebook-github-bot commented 3 days ago

@xiaoxmeng has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

facebook-github-bot commented 2 days ago

@xiaoxmeng merged this pull request in facebookincubator/velox@22392b1756f1373074a86dfd6ccbd4812ef9b78f.

conbench-facebook[bot] commented 2 days ago

Conbench analyzed the 1 benchmark run on commit 22392b17.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details.