search

facebookincubator / velox

A composable and fully extensible C++ execution engine library for data management systems.
https://velox-lib.io/
Apache License 2.0
3.53k stars 1.16k forks source link

refactor(sparksql): Speed up sparksql compilation times by split sparksql registration code into serval cpp files #11565

Open Yohahaha opened 6 days ago

Yohahaha commented 6 days ago

This PR aims to speed up sparksql compilation times, sparksql registration code was split from velox_functions_spark, and rename old velox_functions_spark to velox_functions_spark_impl to follow prestosql's naming.

And different types of function registration code be split from Register.cpp into serval cpp files.

Fixes #11564

netlify[bot] commented 6 days ago

Deploy Preview for meta-velox ready!

Name Link
Latest commit e2b42945b2950646762961e3c95f8234e8364c30
Latest deploy log https://app.netlify.com/sites/meta-velox/deploys/673e966b4a248700083bbcd4
Deploy Preview https://deploy-preview-11565--meta-velox.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Yohahaha commented 6 days ago

@PHILO-HE @rui-mo @mbasmanova would you help review this PR? it's help speed up sparksql compilation time.

Yohahaha commented 4 days ago

@FelixYBW @majetideepak @pedroerp would you help review this PR? it's help speed up sparksql complication times.

Yohahaha commented 3 days ago

@rui-mo would you help review again?