facebookincubator / velox

A composable and fully extensible C++ execution engine library for data management systems.
https://velox-lib.io/
Apache License 2.0
3.54k stars 1.17k forks source link

misc: Add macros for Velox::Expected #11570

Closed marin-ma closed 5 days ago

marin-ma commented 1 week ago

Add macros VELOX_RETURN_UNEXPECTED_IF, VELOX_RETURN_UNEXPECTED_NOT_OK and VELOX_RETURN_UNEXPECTED.

netlify[bot] commented 1 week ago

Deploy Preview for meta-velox canceled.

Name Link
Latest commit c419c885df2341fc3650e42c42e69ce8ec38f036
Latest deploy log https://app.netlify.com/sites/meta-velox/deploys/674014046b1ea4000833856e
marin-ma commented 1 week ago

@pedroerp Could you help to review? Thanks!

facebook-github-bot commented 6 days ago

@kagamiori has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

facebook-github-bot commented 5 days ago

@kagamiori merged this pull request in facebookincubator/velox@55046e6b4275e99146f3521b780225d4f51b4b95.

conbench-facebook[bot] commented 5 days ago

Conbench analyzed the 1 benchmark run on commit 55046e6b.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details.