search

facebookincubator / velox

A composable and fully extensible C++ execution engine library for data management systems.
https://velox-lib.io/
Apache License 2.0
3.53k stars 1.16k forks source link

fix: Unaligned memory access in ByteStream and PrestoSerializer #11574

Closed Yuhta closed 5 days ago

Yuhta commented 6 days ago

Summary: We have a few places in the serialization code that do unaligned memory access. This is causing crashes in ByteOutputStream::append<int128> and we clean them up in this change.

Differential Revision: D66125705

netlify[bot] commented 6 days ago

Deploy Preview for meta-velox canceled.

Name Link
Latest commit c44d65dd6161e700fd98f5219fc66dcb8a434f58
Latest deploy log https://app.netlify.com/sites/meta-velox/deploys/673cbcf51617b50007d99ce7
facebook-github-bot commented 6 days ago

This pull request was exported from Phabricator. Differential Revision: D66125705

facebook-github-bot commented 5 days ago

This pull request was exported from Phabricator. Differential Revision: D66125705

facebook-github-bot commented 5 days ago

This pull request has been merged in facebookincubator/velox@af6609d5d3696c87731de67ab41e9eae19e2dd53.

conbench-facebook[bot] commented 5 days ago

Conbench analyzed the 1 benchmark run on commit af6609d5.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details.