search

facebookincubator / velox

A composable and fully extensible C++ execution engine library for data management systems.
https://velox-lib.io/
Apache License 2.0
3.54k stars 1.17k forks source link

build(fuzzer): Enable biased expression fuzzer with PQR for single functions at PR time #11581

Closed kagamiori closed 6 days ago

kagamiori commented 1 week ago

When a PR adds or modifies a Presto function, make the expression fuzzer run with only this function and verify the result against Presto.

Differential Revision: D66141945

netlify[bot] commented 1 week ago

Deploy Preview for meta-velox canceled.

Name Link
Latest commit 9ee9cc3d090e5b17becd518b35fdda6867a22e95
Latest deploy log https://app.netlify.com/sites/meta-velox/deploys/6740133b38062600086c4dbb
facebook-github-bot commented 1 week ago

This pull request was exported from Phabricator. Differential Revision: D66141945

assignUser commented 6 days ago

@kagamiori you still need to revert the mock changes

kagamiori commented 6 days ago

@kagamiori you still need to revert the mock changes

@assignUser Yeah, I know. Don't worry. I was formatting the script and removing some unnecessary commands. So updating the PR to ensure it works fine in CI before I merge the code.

assignUser commented 6 days ago

Makes sense, thanks!

facebook-github-bot commented 6 days ago

This pull request was exported from Phabricator. Differential Revision: D66141945

facebook-github-bot commented 6 days ago

This pull request has been merged in facebookincubator/velox@fca62d11a9265b20e269eeef619e7cc0aaaca08e.

conbench-facebook[bot] commented 6 days ago

Conbench analyzed the 1 benchmark run on commit fca62d11.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details.

assignUser commented 2 days ago

@kagamiori you introduced some syntax breaking indentation in your last rebase, fix here #11652