search

facebookincubator / velox

A composable and fully extensible C++ execution engine library for data management systems.
https://velox-lib.io/
Apache License 2.0
3.54k stars 1.17k forks source link

fix(hdfs): Include the connection failure reason #11586

Closed Yohahaha closed 1 week ago

netlify[bot] commented 1 week ago

Deploy Preview for meta-velox canceled.

Name Link
Latest commit f4b1b67d2dfe8a0e4c040266479258aa58561e34
Latest deploy log https://app.netlify.com/sites/meta-velox/deploys/673d3d75f04e710008f4fbed
Yohahaha commented 1 week ago

@JkSelf please help take a look, thank you!

JkSelf commented 1 week ago

@JkSelf please help take a look, thank you!

@Yohahaha Thanks for your fix. Can you help to figure out the different error message in the PR description? Thanks.

Yohahaha commented 1 week ago

@JkSelf please help take a look, thank you!

@Yohahaha Thanks for your fix. Can you help to figure out the different error message in the PR description? Thanks.

maybe not.. error message depends on specific error path, show error message better then guess what happened I think.

Yohahaha commented 1 week ago

@majetideepak would you help review again? thank you!

facebook-github-bot commented 1 week ago

@kagamiori has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

facebook-github-bot commented 1 week ago

@kagamiori merged this pull request in facebookincubator/velox@ebfb1e56f23586461194d58a97d6407def176e58.

conbench-facebook[bot] commented 1 week ago

Conbench analyzed the 1 benchmark run on commit ebfb1e56.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details.