search

facebookincubator / velox

A composable and fully extensible C++ execution engine library for data management systems.
https://velox-lib.io/
Apache License 2.0
3.54k stars 1.17k forks source link

fix: Add include cstdint explicitly #11594

Closed yabinma closed 1 week ago

yabinma commented 1 week ago

Description: Without the explicit include, it throws error with gcc 13.2 on Ubuntu 24.04. The fix is to specify it explicitly.

netlify[bot] commented 1 week ago

Deploy Preview for meta-velox canceled.

Name Link
Latest commit 97550aefa5c7ef9fea43e73bf2ac11d6e56c4750
Latest deploy log https://app.netlify.com/sites/meta-velox/deploys/673d1326b9d2110008255bde
czentgr commented 1 week ago

@majetideepak FYI.

facebook-github-bot commented 1 week ago

@kagamiori has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

facebook-github-bot commented 1 week ago

@kagamiori merged this pull request in facebookincubator/velox@c13b8ed888aa785bff88d061f5b3bc00e9231961.

conbench-facebook[bot] commented 1 week ago

Conbench analyzed the 1 benchmark run on commit c13b8ed8.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details.