search

facebookincubator / velox

A composable and fully extensible C++ execution engine library for data management systems.
https://velox-lib.io/
Apache License 2.0
3.54k stars 1.17k forks source link

fix: Clamp values in Breeze unit test to prevent overflow #11618

Closed dreveman closed 5 days ago

dreveman commented 6 days ago

Fixes ubsan test failure.

netlify[bot] commented 6 days ago

Deploy Preview for meta-velox canceled.

Name Link
Latest commit ed68c1c5733e539730334b5f8a98f9311cfeb0e2
Latest deploy log https://app.netlify.com/sites/meta-velox/deploys/67407ca3a060ec0008327fd6
facebook-github-bot commented 6 days ago

@kagamiori has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

facebook-github-bot commented 5 days ago

@kagamiori has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

facebook-github-bot commented 5 days ago

@kagamiori merged this pull request in facebookincubator/velox@46207187138d35700c323005fe658b7d5c9cf71b.

conbench-facebook[bot] commented 5 days ago

Conbench analyzed the 1 benchmark run on commit 46207187.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details.