search

facebookincubator / velox

A composable and fully extensible C++ execution engine library for data management systems.
https://velox-lib.io/
Apache License 2.0
3.54k stars 1.17k forks source link

fix: Let SharedArbitrator check leak only when dbg #11621

Closed tanjialiang closed 2 days ago

tanjialiang commented 6 days ago

The current leak check behavior is not consistent between memory pool and shared arbitrator. Memory pool prints error message and logs metrics but not fail. However shared arbitrator throw failures. And when it does there is no wrapping exception handling so it will crash entire server. Change shared arbitrator behavior to be consistent with memory pool by do the deadly check only in debug mode

netlify[bot] commented 6 days ago

Deploy Preview for meta-velox canceled.

Name Link
Latest commit e77d8734592ac47bea694e644fad8ef063dbedb9
Latest deploy log https://app.netlify.com/sites/meta-velox/deploys/673fcbb1228bf40008e37723
facebook-github-bot commented 6 days ago

@tanjialiang has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

tanjialiang commented 2 days ago

Abandoning