search

facebookincubator / velox

A C++ vectorized database acceleration library aimed to optimizing query engines and data processing systems.
https://velox-lib.io/
Apache License 2.0
3.41k stars 1.11k forks source link

Implement current_time Presto Function #4466

Open minhancao opened 1 year ago

minhancao commented 1 year ago

Description

Add missing function to handle current_time prestosql function.

Please assign it to me, thanks!

aditi-pandit commented 1 year ago

@pedroerp, @mbasmanova : Should we implement current_time prestosql function at the Velox layer ? For Presto server, I would expect this function to be evaluated at the co-ordinator itself.

mbasmanova commented 1 year ago

It won't hurt to have this function available in Velox, but it won't be used by Prestissimo since it will be evaluated during query planning.

yiweiHeOSS commented 1 year ago

I am working together with @minhancao on this issue, please assign it to me as well. Thanks.

pedroerp commented 1 year ago

+1. It would be nice to have a full implementation of the Presto function dialect for use cases outside of Prestissimo. @yiweiHeOSS @minhancao just assigned it to you.