facebookincubator / velox

A composable and fully extensible C++ execution engine library for data management systems.
https://velox-lib.io/
Apache License 2.0
3.54k stars 1.16k forks source link

Implement IpAddressType #7591

Open amitkdutta opened 1 year ago

amitkdutta commented 1 year ago

Description

IpAddressType is implemented as a type in Presto. It will be great to have this in Velox to support queries using this type.

CC: @pedroerp @aditi-pandit @kagamiori @mbasmanova @majetideepak @laithsakka

aditi-pandit commented 1 year ago

@amitkdutta : IPAddressType should be a customType in Prestissimo (instead of a Velox type) imo

It feels more natural to implement this in presto-native-execution submodule to me.

@mbasmanova, @pedroerp : wdyt ?

Yuhta commented 1 year ago

I would suggest to put it under velox/types/presto. The underlying physical type is int128, and there will be quite a few places in the core library need to be fixed when we hard code int128 to be long decimal, so it will be much easier if we can put all the changes in one repo. Also this way the functions can be put in velox/functions/prestosql with better fuzzer support etc.