search

facebookincubator / velox

A C++ vectorized database acceleration library aimed to optimizing query engines and data processing systems.
https://velox-lib.io/
Apache License 2.0
3.41k stars 1.11k forks source link

PyVelox pipeline build for MacOS fails when running install_fbthrift #8635

Open czentgr opened 7 months ago

czentgr commented 7 months ago

Bug description

PR pipeline builds fail with an error using fbthrift while running install_fbthrift. Example: https://github.com/facebookincubator/velox/actions/runs/7737097416/job/21095520461?pr=8481

System information

N/A

Relevant logs

[88/348] Linking CXX executable bin/thrift1
[89/348] Generating cpp files. Output: /Users/runner/work/velox/velox/fbthrift/_build/thrift/annotation

FAILED: thrift/annotation/gen-cpp2/cpp_constants.h thrift/annotation/gen-cpp2/cpp_data.h thrift/annotation/gen-cpp2/cpp_metadata.h thrift/annotation/gen-cpp2/cpp_types.h thrift/annotation/gen-cpp2/cpp_types.tcc thrift/annotation/gen-cpp2/cpp_constants.cpp thrift/annotation/gen-cpp2/cpp_data.cpp thrift/annotation/gen-cpp2/cpp_types.cpp /Users/runner/work/velox/velox/fbthrift/_build/thrift/annotation/gen-cpp2/cpp_constants.h /Users/runner/work/velox/velox/fbthrift/_build/thrift/annotation/gen-cpp2/cpp_data.h /Users/runner/work/velox/velox/fbthrift/_build/thrift/annotation/gen-cpp2/cpp_metadata.h /Users/runner/work/velox/velox/fbthrift/_build/thrift/annotation/gen-cpp2/cpp_types.h /Users/runner/work/velox/velox/fbthrift/_build/thrift/annotation/gen-cpp2/cpp_types.tcc /Users/runner/work/velox/velox/fbthrift/_build/thrift/annotation/gen-cpp2/cpp_constants.cpp /Users/runner/work/velox/velox/fbthrift/_build/thrift/annotation/gen-cpp2/cpp_data.cpp /Users/runner/work/velox/velox/fbthrift/_build/thrift/annotation/gen-cpp2/cpp_types.cpp 
real    3m35.702s
cd /Users/runner/work/velox/velox/fbthrift/_build/thrift/annotation && /Users/runner/work/velox/velox/fbthrift/_build/bin/thrift1 --gen mstch_cpp2:templates,no_metadata,include_prefix=thrift/annotation -o /Users/runner/work/velox/velox/fbthrift/_build/thrift/annotation -I /Users/runner/work/velox/velox/fbthrift /Users/runner/work/velox/velox/fbthrift/thrift/annotation/cpp.thrift
user    6m17.368s
/bin/sh: line 1: 86602 Illegal instruction: 4  /Users/runner/work/velox/velox/fbthrift/_build/bin/thrift1 --gen mstch_cpp2:templates,no_metadata,include_prefix=thrift/annotation -o /Users/runner/work/velox/velox/fbthrift/_build/thrift/annotation -I /Users/runner/work/velox/velox/fbthrift /Users/runner/work/velox/velox/fbthrift/thrift/annotation/cpp.thrift
sys 0m29.961s
[90/348] Generating go files. Output: /Users/runner/work/velox/velox/fbthrift/_build/thrift/annotation
+ echo 'Failed to run install_fbthrift .'
FAILED: thrift/annotation/gen-cpp2/go_constants.h thrift/annotation/gen-cpp2/go_data.h thrift/annotation/gen-cpp2/go_metadata.h thrift/annotation/gen-cpp2/go_types.h thrift/annotation/gen-cpp2/go_types.tcc thrift/annotation/gen-cpp2/go_constants.cpp thrift/annotation/gen-cpp2/go_data.cpp thrift/annotation/gen-cpp2/go_types.cpp /Users/runner/work/velox/velox/fbthrift/_build/thrift/annotation/gen-cpp2/go_constants.h /Users/runner/work/velox/velox/fbthrift/_build/thrift/annotation/gen-cpp2/go_data.h /Users/runner/work/velox/velox/fbthrift/_build/thrift/annotation/gen-cpp2/go_metadata.h /Users/runner/work/velox/velox/fbthrift/_build/thrift/annotation/gen-cpp2/go_types.h /Users/runner/work/velox/velox/fbthrift/_build/thrift/annotation/gen-cpp2/go_types.tcc /Users/runner/work/velox/velox/fbthrift/_build/thrift/annotation/gen-cpp2/go_constants.cpp /Users/runner/work/velox/velox/fbthrift/_build/thrift/annotation/gen-cpp2/go_data.cpp /Users/runner/work/velox/velox/fbthrift/_build/thrift/annotation/gen-cpp2/go_types.cpp 
+ exit 1
cd /Users/runner/work/velox/velox/fbthrift/_build/thrift/annotation && /Users/runner/work/velox/velox/fbthrift/_build/bin/thrift1 --gen mstch_cpp2:templates,no_metadata,include_prefix=thrift/annotation -o /Users/runner/work/velox/velox/fbthrift/_build/thrift/annotation -I /Users/runner/work/velox/velox/fbthrift /Users/runner/work/velox/velox/fbthrift/thrift/annotation/go.thrift
/bin/sh: line 1: 86606 Illegal instruction: 4  /Users/runner/work/velox/velox/fbthrift/_build/bin/thrift1 --gen mstch_cpp2:templates,no_metadata,include_prefix=thrift/annotation -o /Users/runner/work/velox/velox/fbthrift/_build/thrift/annotation -I /Users/runner/work/velox/velox/fbthrift /Users/runner/work/velox/velox/fbthrift/thrift/annotation/go.thrift
[91/348] Generating java files. Output: /Users/runner/work/velox/velox/fbthrift/_build/thrift/annotation
FAILED: thrift/annotation/gen-cpp2/java_constants.h thrift/annotation/gen-cpp2/java_data.h thrift/annotation/gen-cpp2/java_metadata.h thrift/annotation/gen-cpp2/java_types.h thrift/annotation/gen-cpp2/java_types.tcc thrift/annotation/gen-cpp2/java_constants.cpp thrift/annotation/gen-cpp2/java_data.cpp thrift/annotation/gen-cpp2/java_types.cpp /Users/runner/work/velox/velox/fbthrift/_build/thrift/annotation/gen-cpp2/java_constants.h /Users/runner/work/velox/velox/fbthrift/_build/thrift/annotation/gen-cpp2/java_data.h /Users/runner/work/velox/velox/fbthrift/_build/thrift/annotation/gen-cpp2/java_metadata.h /Users/runner/work/velox/velox/fbthrift/_build/thrift/annotation/gen-cpp2/java_types.h /Users/runner/work/velox/velox/fbthrift/_build/thrift/annotation/gen-cpp2/java_types.tcc /Users/runner/work/velox/velox/fbthrift/_build/thrift/annotation/gen-cpp2/java_constants.cpp /Users/runner/work/velox/velox/fbthrift/_build/thrift/annotation/gen-cpp2/java_data.cpp /Users/runner/work/velox/velox/fbthrift/_build/thrift/annotation/gen-cpp2/java_types.cpp 
cd /Users/runner/work/velox/velox/fbthrift/_build/thrift/annotation && /Users/runner/work/velox/velox/fbthrift/_build/bin/thrift1 --gen mstch_cpp2:templates,no_metadata,include_prefix=thrift/annotation -o /Users/runner/work/velox/velox/fbthrift/_build/thrift/annotation -I /Users/runner/work/velox/velox/fbthrift /Users/runner/work/velox/velox/fbthrift/thrift/annotation/java.thrift
/bin/sh: line 1: 86605 Illegal instruction: 4  /Users/runner/work/velox/velox/fbthrift/_build/bin/thrift1 --gen mstch_cpp2:templates,no_metadata,include_prefix=thrift/annotation -o /Users/runner/work/velox/velox/fbthrift/_build/thrift/annotation -I /Users/runner/work/velox/velox/fbthrift /Users/runner/work/velox/velox/fbthrift/thrift/annotation/java.thrift
[92/348] Generating hack files. Output: /Users/runner/work/velox/velox/fbthrift/_build/thrift/annotation
FAILED: thrift/annotation/gen-cpp2/hack_constants.h thrift/annotation/gen-cpp2/hack_data.h thrift/annotation/gen-cpp2/hack_metadata.h thrift/annotation/gen-cpp2/hack_types.h thrift/annotation/gen-cpp2/hack_types.tcc thrift/annotation/gen-cpp2/hack_constants.cpp thrift/annotation/gen-cpp2/hack_data.cpp thrift/annotation/gen-cpp2/hack_types.cpp /Users/runner/work/velox/velox/fbthrift/_build/thrift/annotation/gen-cpp2/hack_constants.h /Users/runner/work/velox/velox/fbthrift/_build/thrift/annotation/gen-cpp2/hack_data.h /Users/runner/work/velox/velox/fbthrift/_build/thrift/annotation/gen-cpp2/hack_metadata.h /Users/runner/work/velox/velox/fbthrift/_build/thrift/annotation/gen-cpp2/hack_types.h /Users/runner/work/velox/velox/fbthrift/_build/thrift/annotation/gen-cpp2/hack_types.tcc /Users/runner/work/velox/velox/fbthrift/_build/thrift/annotation/gen-cpp2/hack_constants.cpp /Users/runner/work/velox/velox/fbthrift/_build/thrift/annotation/gen-cpp2/hack_data.cpp /Users/runner/work/velox/velox/fbthrift/_build/thrift/annotation/gen-cpp2/hack_types.cpp 
cd /Users/runner/work/velox/velox/fbthrift/_build/thrift/annotation && /Users/runner/work/velox/velox/fbthrift/_build/bin/thrift1 --gen mstch_cpp2:templates,no_metadata,include_prefix=thrift/annotation -o /Users/runner/work/velox/velox/fbthrift/_build/thrift/annotation -I /Users/runner/work/velox/velox/fbthrift /Users/runner/work/velox/velox/fbthrift/thrift/annotation/hack.thrift
/bin/sh: line 1: 86603 Illegal instruction: 4  /Users/runner/work/velox/velox/fbthrift/_build/bin/thrift1 --gen mstch_cpp2:templates,no_metadata,include_prefix=thrift/annotation -o /Users/runner/work/velox/velox/fbthrift/_build/thrift/annotation -I /Users/runner/work/velox/velox/fbthrift /Users/runner/work/velox/velox/fbthrift/thrift/annotation/hack.thrift
[93/348] Generating python files. Output: /Users/runner/work/velox/velox/fbthrift/_build/thrift/annotation
FAILED: thrift/annotation/gen-cpp2/python_constants.h thrift/annotation/gen-cpp2/python_data.h thrift/annotation/gen-cpp2/python_metadata.h thrift/annotation/gen-cpp2/python_types.h thrift/annotation/gen-cpp2/python_types.tcc thrift/annotation/gen-cpp2/python_constants.cpp thrift/annotation/gen-cpp2/python_data.cpp thrift/annotation/gen-cpp2/python_types.cpp /Users/runner/work/velox/velox/fbthrift/_build/thrift/annotation/gen-cpp2/python_constants.h /Users/runner/work/velox/velox/fbthrift/_build/thrift/annotation/gen-cpp2/python_data.h /Users/runner/work/velox/velox/fbthrift/_build/thrift/annotation/gen-cpp2/python_metadata.h /Users/runner/work/velox/velox/fbthrift/_build/thrift/annotation/gen-cpp2/python_types.h /Users/runner/work/velox/velox/fbthrift/_build/thrift/annotation/gen-cpp2/python_types.tcc /Users/runner/work/velox/velox/fbthrift/_build/thrift/annotation/gen-cpp2/python_constants.cpp /Users/runner/work/velox/velox/fbthrift/_build/thrift/annotation/gen-cpp2/python_data.cpp /Users/runner/work/velox/velox/fbthrift/_build/thrift/annotation/gen-cpp2/python_types.cpp 
cd /Users/runner/work/velox/velox/fbthrift/_build/thrift/annotation && /Users/runner/work/velox/velox/fbthrift/_build/bin/thrift1 --gen mstch_cpp2:templates,no_metadata,include_prefix=thrift/annotation -o /Users/runner/work/velox/velox/fbthrift/_build/thrift/annotation -I /Users/runner/work/velox/velox/fbthrift /Users/runner/work/velox/velox/fbthrift/thrift/annotation/python.thrift
/bin/sh: line 1: 86604 Illegal instruction: 4  /Users/runner/work/velox/velox/fbthrift/_build/bin/thrift1 --gen mstch_cpp2:templates,no_metadata,include_prefix=thrift/annotation -o /Users/runner/work/velox/velox/fbthrift/_build/thrift/annotation -I /Users/runner/work/velox/velox/fbthrift /Users/runner/work/velox/velox/fbthrift/thrift/annotation/python.thrift
ninja: build stopped: subcommand failed.
Failed to run install_fbthrift .
Error: Process completed with exit code 1.
kgpai commented 7 months ago

cc: @assignUser

kgpai commented 7 months ago

I am going to disable that while we investigate a fix.