search

facebookincubator / velox

A C++ vectorized database acceleration library aimed to optimizing query engines and data processing systems.
https://velox-lib.io/
Apache License 2.0
3.46k stars 1.13k forks source link

Add support for aggregate signatures in CI Bias check logic #8930

Open kgpai opened 7 months ago

kgpai commented 7 months ago

Description

We need to add support for aggregate signatures in CI Bias check logic to detect backwards incompatible changes. Example PR: https://github.com/facebookincubator/velox/pull/8381 .

Currently this can be done by :

  1. Adding support for aggregate signatures (both Spark/Presto) in signatures.cpp in pyvelox (https://github.com/facebookincubator/velox/blob/main/pyvelox/signatures.cpp) .
  2. Add support in https://github.com/facebookincubator/velox/blob/main/scripts/signature.py to load these signatures . Adding support for load should automatically enable finding changed signatures.
  3. AggregationFuzzer currently doesnt support biasing of functions, but does support using the 'only' flag which will have to be used to ensure we test the changes out throughly.
mbasmanova commented 7 months ago

CC: @kagamiori @bikramSingh91