facebookincubator / velox

A C++ vectorized database acceleration library aimed to optimizing query engines and data processing systems.
https://velox-lib.io/
Apache License 2.0
3.2k stars 1.06k forks source link

Remove unused-but-set variables in velox/common/caching/tests/SsdFileTest.cpp +16 #9828

Closed r-barnes closed 1 week ago

r-barnes commented 2 weeks ago

Summary: This diff removes a variable that was set, but which was not used.

LLVM-15 has a warning -Wunused-but-set-variable which we treat as an error because it's so often diagnostic of a code issue. Unused but set variables often indicate a programming mistake, but can also just be unnecessary cruft that harms readability and performance.

Removing this variable will not change how your code works, but the unused variable may indicate your code isn't working the way you thought it was. If you feel the diff needs changes before landing, please commandeer and make appropriate changes: there are hundreds of these and responding to them individually is challenging.

For questions/comments, contact r-barnes.

Reviewed By: palmje

Differential Revision: D57336836

facebook-github-bot commented 2 weeks ago

This pull request was exported from Phabricator. Differential Revision: D57336836

netlify[bot] commented 2 weeks ago

Deploy Preview for meta-velox canceled.

Name Link
Latest commit 07fc4a274c13ab71e541410ebba70701e9074fea
Latest deploy log https://app.netlify.com/sites/meta-velox/deploys/664f82c096c83f0008d898e0
facebook-github-bot commented 1 week ago

This pull request was exported from Phabricator. Differential Revision: D57336836

facebook-github-bot commented 1 week ago

This pull request was exported from Phabricator. Differential Revision: D57336836

facebook-github-bot commented 1 week ago

This pull request was exported from Phabricator. Differential Revision: D57336836

facebook-github-bot commented 1 week ago

This pull request was exported from Phabricator. Differential Revision: D57336836

facebook-github-bot commented 1 week ago

This pull request has been merged in facebookincubator/velox@179fefc4ee81711557db2f415b9cf7dd866390c8.