facebookincubator / velox

A C++ vectorized database acceleration library aimed to optimizing query engines and data processing systems.
https://velox-lib.io/
Apache License 2.0
3.2k stars 1.06k forks source link

Optimize the shared leaf memory pool locking #9830

Closed xiaoxmeng closed 2 weeks ago

xiaoxmeng commented 2 weeks ago

Avoid the global locking when access shared leaf memory pool:

  1. remove the global lock access to the single-ton memory manager
  2. remove the global lock to access shared leaf pool array

Next step is to work with Meta internal teams to deprecate such use cases with explicit leaf memory pool lifecycle management at user side as well as explicit memory manager initialization.

netlify[bot] commented 2 weeks ago

Deploy Preview for meta-velox canceled.

Name Link
Latest commit fd4f75b7264f93f47ff3edb6c2dd9a0edd3a1ae0
Latest deploy log https://app.netlify.com/sites/meta-velox/deploys/664643fcc0ded800086431d8
facebook-github-bot commented 2 weeks ago

@xiaoxmeng has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

facebook-github-bot commented 2 weeks ago

@xiaoxmeng has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

facebook-github-bot commented 2 weeks ago

@xiaoxmeng has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

facebook-github-bot commented 2 weeks ago

@xiaoxmeng has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

facebook-github-bot commented 2 weeks ago

@xiaoxmeng has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

facebook-github-bot commented 2 weeks ago

This pull request was exported from Phabricator. Differential Revision: D57405421

facebook-github-bot commented 2 weeks ago

@xiaoxmeng merged this pull request in facebookincubator/velox@2b94547ea972b38adaad54c2d8b014f62cb587b8.

conbench-facebook[bot] commented 2 weeks ago

Conbench analyzed the 1 benchmark run on commit 2b94547e.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details.