search

facebookincubator / velox

A C++ vectorized database acceleration library aimed to optimizing query engines and data processing systems.
https://velox-lib.io/
Apache License 2.0
3.2k stars 1.06k forks source link

Spark mod function supports float/double types #9848

Open lyy-pineapple opened 2 weeks ago

lyy-pineapple commented 2 weeks ago

Spark mod support float/double types

(https://github.com/apache/spark/blob/403619a3974c595ba80d6c9dbd23b8c2f1e2233e/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/arithmetic.scala#L899)

facebook-github-bot commented 2 weeks ago

Hi @lyy-pineapple!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

netlify[bot] commented 2 weeks ago

Deploy Preview for meta-velox canceled.

Name Link
Latest commit aee208fd4d75ff7eca62015227762c7cb57aebb6
Latest deploy log https://app.netlify.com/sites/meta-velox/deploys/664f3d58f2fa260008fb829a
lyy-pineapple commented 1 week ago

@Yuhta @xiaoxmeng Hey, could you take a look at this patch?