search

facebookincubator / xar

executable archive format
Other
1.57k stars 55 forks source link

UserWarning when install #33

Closed Hanaasagi closed 5 years ago

Hanaasagi commented 5 years ago

Run python setup.py install 

/usr/lib64/python3.7/distutils/dist.py:274: UserWarning: Unknown distribution option: 'test_require'
  warnings.warn(msg)

https://github.com/facebookincubator/xar/blob/38398a19651dc1d8b6b1e0206c6a6fff7a2aae08/setup.py#L44

It should be tests_require instead of test_requires.

Ref: https://setuptools.readthedocs.io/en/latest/setuptools.html?highlight=tests_require#new-and-changed-setup-keywords

cooperlees commented 5 years ago

Thanks for finding this. PR welcome or we will try get to it this week.

Hanaasagi commented 5 years ago

Done.