search

facebookincubator / xar

executable archive format
Other
1.57k stars 55 forks source link

fix NOGROUP detection by os #40

Closed darjeeling closed 4 years ago

darjeeling commented 4 years ago

In CentOS, nobody is used instead of nogroup in debian based distro. but in python platform module can't detect distro. so testing with grp module will determine NOGROUP better than platform module

facebook-github-bot commented 4 years ago

Hi @darjeeling!

Thank you for your pull request and welcome to our community.We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file.

In order for us to review and merge your code, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

facebook-github-bot commented 4 years ago

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!