search

facebookincubator / xar

executable archive format
Other
1.57k stars 55 forks source link

Add Logging file to xarlib_srcs #48

Closed dusty-phillips closed 2 years ago

dusty-phillips commented 2 years ago

I have a feeling the open source build has been broken (at least for MacOS) since https://github.com/facebookincubator/xar/commit/a4c59465d7550c0e26041114d213076bc9ad49ac

I was getting a linking error against Logging.h, repro'd with both clang and gcc. Explicitly adding that dependency to the xarlib_srcs set has the binary compiling successfully for me now.

facebook-github-bot commented 2 years ago

Hi @dusty-phillips!

Thank you for your pull request.

We require contributors to sign our Contributor License Agreement, and yours needs attention.

You currently have a record in our system, but the CLA is no longer valid, and will need to be resubmitted.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

dusty-phillips commented 2 years ago

That serves me right for quitting, I guess. Have signed now.

dusty-phillips commented 2 years ago

I had some “mumble mumble buck” moments.

facebook-github-bot commented 2 years ago

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

facebook-github-bot commented 2 years ago

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

facebook-github-bot commented 2 years ago

@cooperlees has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.