Wrong results when value is negative using maximum in GetImageGradient function

facebookresearch / AR-Depth

Fast Depth Densification for Occlusion-Aware Augmented Reality

Other

219 stars 49 forks source link

Wrong results when value is negative using maximum in GetImageGradient function #3

Closed huayong closed 5 years ago

huayong commented 5 years ago

If rgb gradients all are positive, maximum get max gradient. But If rgb gradients all are negative, maximum get min gradient. It seems that the code is not correct.

holynski commented 5 years ago

Thanks for pointing this out -- I just pushed a fix. Can you confirm that it's now doing what it should?

huayong commented 5 years ago

Thanks for your reply and revision. I have checked the results using AbsoluteMaximum function, it's right. And I think you also should update the maximum to AbsoluteMaximum in Canny function.

holynski commented 5 years ago

There, I added that one too.

Does that fix everything?

huayong commented 5 years ago

Yeah.

holynski commented 5 years ago

Cool, closing the issue.