search

facebookresearch / ATEK

Aria Training and Evaluation Kit
Apache License 2.0
13 stars 1 forks source link

Add CubeRCNN training and inference pipeline #2

Closed zhengkang86 closed 10 months ago

facebook-github-bot commented 10 months ago

@chengshy has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

chengshy commented 10 months ago

This is a giant diff which combines all the change including functionaly change, bug fixes, config file change, scripts , etc. It mixed some stable clean changes with bunch of hacky changes. Kinda hard to clean it up base on the timeline and things we trying to achieve at this moment. I added some clean up and consolidation to the data loader part.

@zhengkang86 @chpeng-fb Few suggestions going forward here,

  1. Let's don't do this mega diff to inflate changes any more, do clear boundary for each features and sends smaller cleaner diffs for review. I think that will generally forcing a better code quality with interface design requried.
  2. Refactor the whole infer pipeline with the new data loader, make the infer pipeline more generic and reusable, a cubeRCNN infer entry point file could use that for generating both eval results as well as the visualizations.
  3. Clean up the scripts and config files, with a better folder structure.
facebook-github-bot commented 10 months ago

@chengshy merged this pull request in fairinternal/ATEK@18c34863245d06fb9d2cf7722da8b12ea1f1f576.