facebookresearch / AVT

Code release for ICCV 2021 paper "Anticipative Video Transformer"
Apache License 2.0
152 stars 28 forks source link

Doubts regarding the Causality #28

Closed Anirudh257 closed 2 years ago

Anirudh257 commented 2 years ago

@rohitgirdhar Thanks for this excellent work and releasing the code.

I went through the code but I am unable to see where the masking of inputs is occurring. In https://github.com/facebookresearch/AVT/blob/2d6781d5315a4c53bd059b1cd11ee46bd4427648/models/future_prediction.py#L178 you directly pass the entire input features to the GPT itself. Does the masking and output per timesteps get taken care by GPT itself?

rohitgirdhar commented 2 years ago

Hi @Anirudh257 thanks for your interest. Yes, the masking operations happen within the GPT implementation itself.

Anirudh257 commented 2 years ago

Thanks for the clarification @rohitgirdhar. I was confused as to how the features were changing at different time-steps.