search

facebookresearch / AnimatedDrawings

Code to accompany "A Method for Animating Children's Drawings of the Human Figure"
MIT License
10.62k stars 936 forks source link

Update annotations_to_animation.py #293

Closed gemmijamz closed 4 months ago

gemmijamz commented 4 months ago

REQUIRED for headless render (ie. if you use Ubuntu)

facebook-github-bot commented 4 months ago

Hi @gemmijamz!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

facebook-github-bot commented 4 months ago

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

hjessmith commented 4 months ago

Hi @gemmijamz

Thanks for your proposed PR, but annotations_to_animation.py is simply an example script showing a very basic use case. I'd prefer to keep it as basic as possible, and allow users to add additional fields, such as USE_MESA, when needed.

gemmijamz commented 4 months ago

@hjessmith Thank you for your message! No problem, it was my mistake and I was just trying to follow your headless rendering instructions and got a bit confused.