facebookresearch / BenchMARL

A collection of MARL benchmarks based on TorchRL
https://benchmarl.readthedocs.io/
MIT License
288 stars 42 forks source link

Impact of using "input" as a variable name in models code #134

Closed Giovannibriglia closed 1 month ago

Giovannibriglia commented 1 month ago

Hi,

I've observed that in the following lines of code (as examples), the variable is named input. Could you please clarify why this specific name is used? Does naming the variable input have any implications for the model's behavior or performance?

Thanks for the clarification!

matteobettini commented 1 month ago

Why would the name of the variable impact performance?

The only consequence it has is that it obscures the built in python input function (which we wouldn't use in models anyway)

Giovannibriglia commented 1 month ago

I had the same thought as you, but I don't think it's the best practice. However, I believe it's still acceptable.

Thanks

matteobettini commented 1 month ago

Yeah i agree not the best choice, but it should not have impact