Vmas/transport task fails to start.

facebookresearch / BenchMARL

A collection of MARL benchmarks based on TorchRL

https://benchmarl.readthedocs.io/

MIT License

216 stars 27 forks source link

Vmas/transport task fails to start. #43

Closed balamir53 closed 7 months ago

balamir53 commented 7 months ago

Starting a training via cli 'python benchmarl/run.py algorithm=mappo task=vmas/transport' gives the error after a while (changing max steps in transport.yaml belates the raise error function hit):

BenchMARL/.venv/lib/python3.10/site-packages/torchrl/envs/common.py", line 1527, in _reset_check_done raise RuntimeError( RuntimeError: Env done entry 'done' was (partially) True after reset on specified '_reset' dimensions. This is not allowed.

matteobettini commented 7 months ago

Hey, thanks for posting this!

Could you share your versions of vmas and torchrl?

balamir53 commented 7 months ago

vmas==1.3.3 torchrl==0.2.1

matteobettini commented 7 months ago

I found the issue in TorchRL and opened an issue for you. https://github.com/pytorch/rl/issues/1806

I will also fix this in VMAS and make sure the package is never spawned on the goal

matteobettini commented 7 months ago

The fix in vmas is https://github.com/proroklab/VectorizedMultiAgentSimulator/commit/b434185c8f205d34186b00d23cf4a9e122195863

If you use VMAS main the error should (hopefully) not occour anymore

balamir53 commented 7 months ago

Yeah, that fixed my problem. Thanks.

matteobettini commented 7 months ago

Closing this as solved both in vmas and torchrl