Optimizer inf/nan loss, remove unused optimizer backward - Githubissues

facebookresearch / ClassyVision

An end-to-end PyTorch framework for image and video classification

https://classyvision.ai

MIT License

1.59k stars 278 forks source link

Optimizer inf/nan loss, remove unused optimizer backward #654

Closed abhiskk closed 3 years ago

abhiskk commented 3 years ago

Summary:

Check for loss sanity before calling backward and step, D24740329 (https://github.com/facebookresearch/ClassyVision/commit/1ba6b0354e87c41b5eb26934888d66a55e198b37) modified the order of check.
Remove unused optimizer backward, previously this was re-introduced in D21080585 (https://github.com/facebookresearch/ClassyVision/commit/4a627a1e97d72d02eeeefac52d3d71b13822e835) and rendered useless in D24740329 (https://github.com/facebookresearch/ClassyVision/commit/1ba6b0354e87c41b5eb26934888d66a55e198b37).

Differential Revision: D24955125

facebook-github-bot commented 3 years ago

This pull request was exported from Phabricator. Differential Revision: D24955125

facebook-github-bot commented 3 years ago

This pull request has been merged in facebookresearch/ClassyVision@e2eba06657240de78ae8421ef729c4ffdb7ddf94.