facebookresearch / ClassyVision

An end-to-end PyTorch framework for image and video classification
https://classyvision.ai
MIT License
1.59k stars 278 forks source link

A minor documentation issue in efficientnet #776

Open vinayak015 opened 2 years ago

vinayak015 commented 2 years ago

📚 Documentation

efficientnet.py

It's a clean and well documented code. Kudos to the authors and thank you for making it open source :)

On the line 195, I think it's just an Excitation layer. Squeeze is being done by AdaptiveAvgPool2d.

mannatsingh commented 2 years ago

Glad that you find the implementation useful @vinayak015! You're right, this only corresponds to the "Excitation" part of the SE op. I think the code generally referred to this section as corresponding to the SE layer, but please feel free to send a PR adding a qualifier that this is the Excitation part of the SE layer :)