search

facebookresearch / ClassyVision

An end-to-end PyTorch framework for image and video classification
https://classyvision.ai
MIT License
1.59k stars 278 forks source link

Update util_video.py #777

Closed idiomaticrefactoring closed 2 years ago

idiomaticrefactoring commented 2 years ago

refactoring code with var unpack which is more pythonic, concise, readable and efficient; how do think this change which has practical value？

facebook-github-bot commented 2 years ago

Hi @zjzh!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

facebook-github-bot commented 2 years ago

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

mannatsingh commented 2 years ago

Thanks for the PR @zjzh. While your change is indeed feasible, I believe the original style is more readable and I think we would like to stick to that style. But we welcome other PRs from you in the future!