facebookresearch / CompilerGym

Reinforcement learning environments for compiler and program optimization tasks
https://compilergym.ai/
MIT License
906 stars 127 forks source link

Add permutation and space sequence spaces #645

Closed sogartar closed 2 years ago

sogartar commented 2 years ago

This PR depends on https://github.com/facebookresearch/CompilerGym/pull/643. It has to be merged after it. During review please ignore the first commit and review only the ones after that.

It also assumes that https://github.com/facebookresearch/CompilerGym/pull/644 will be merged before that to have consistency in space comparison. If the space name should not be considered during comparison I will remove it from this PR as well.

codecov-commenter commented 2 years ago

Codecov Report

Merging #645 (fdbbaae) into development (61f460f) will decrease coverage by 1.96%. The diff coverage is 94.87%.

@@               Coverage Diff               @@
##           development     #645      +/-   ##
===============================================
- Coverage        82.10%   80.13%   -1.97%     
===============================================
  Files              116      119       +3     
  Lines             7393     7471      +78     
===============================================
- Hits              6070     5987      -83     
- Misses            1323     1484     +161     
Impacted Files Coverage Δ
compiler_gym/service/proto/__init__.py 100.00% <ø> (ø)
compiler_gym/spaces/space_sequence.py 88.00% <88.00%> (ø)
compiler_gym/spaces/permutation.py 92.85% <92.85%> (ø)
compiler_gym/service/proto/py_converters.py 97.79% <100.00%> (+0.09%) :arrow_up:
compiler_gym/spaces/__init__.py 100.00% <100.00%> (ø)
compiler_gym/util/permutation.py 100.00% <100.00%> (ø)
compiler_gym/envs/gcc/service/gcc_service.py 66.66% <0.00%> (-30.41%) :arrow_down:
compiler_gym/envs/gcc/gcc_rewards.py 80.00% <0.00%> (-20.00%) :arrow_down:
compiler_gym/envs/gcc/gcc_env.py 83.11% <0.00%> (-16.89%) :arrow_down:
compiler_gym/envs/gcc/gcc.py 80.20% <0.00%> (-13.20%) :arrow_down:
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 61f460f...fdbbaae. Read the comment docs.

ChrisCummins commented 2 years ago

@sogartar, there is a merge conflict, feel free to merge yourself after address, or you can ping me to merge.

EDIT: nvm, it was a trivial fix 🙂

Cheers, Chris

sogartar commented 2 years ago

@ChrisCummins, are you going to merge this PR?

ChrisCummins commented 2 years ago

Ah, sorry for the delay! I must have forgot to press the merge button 🙂