facebookresearch / CompilerGym

Reinforcement learning environments for compiler and program optimization tasks
https://compilergym.ai/
MIT License
906 stars 127 forks source link

Fix build hang by removing USES_TERMINAL from Programl Cmake command #703

Closed mostafaelhoushi closed 2 years ago

mostafaelhoushi commented 2 years ago

On my local Linux VM, it seems that removing USES_TERMINAL solves the problem of that 3 hour hang after bazel build. This was based on an uneducated guess :) Let's see if CI will speedup

Fixes #566

codecov-commenter commented 2 years ago

Codecov Report

Merging #703 (2463ecd) into development (45fb0a0) will decrease coverage by 0.35%. The diff coverage is n/a.

@@               Coverage Diff               @@
##           development     #703      +/-   ##
===============================================
- Coverage        88.70%   88.35%   -0.36%     
===============================================
  Files              131      131              
  Lines             7926     7926              
===============================================
- Hits              7031     7003      -28     
- Misses             895      923      +28     
Impacted Files Coverage Δ
...ompiler_gym/service/client_service_compiler_env.py 87.94% <0.00%> (-2.92%) :arrow_down:
compiler_gym/views/observation_space_spec.py 82.85% <0.00%> (-2.86%) :arrow_down:
compiler_gym/views/observation.py 97.29% <0.00%> (-2.71%) :arrow_down:
compiler_gym/service/service_cache.py 89.47% <0.00%> (-2.64%) :arrow_down:
compiler_gym/envs/llvm/llvm_benchmark.py 90.97% <0.00%> (-2.09%) :arrow_down:
compiler_gym/util/runfiles_path.py 89.28% <0.00%> (-1.79%) :arrow_down:
compiler_gym/envs/llvm/datasets/cbench.py 79.06% <0.00%> (-1.45%) :arrow_down:
compiler_gym/service/connection.py 76.66% <0.00%> (-1.00%) :arrow_down:
compiler_gym/envs/gcc/gcc.py 93.14% <0.00%> (-0.26%) :arrow_down:
...loop_tool/service/loop_tool_compilation_session.py 90.54% <0.00%> (+0.67%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 45fb0a0...2463ecd. Read the comment docs.

mostafaelhoushi commented 2 years ago

build-linux-cmake now takes 34 minutes!

image
ChrisCummins commented 2 years ago

Superstar! Thank you @mostafaelhoushi

ChrisCummins commented 2 years ago