search

facebookresearch / CompilerGym

Reinforcement learning environments for compiler and program optimization tasks
https://compilergym.ai/
MIT License
906 stars 127 forks source link

[bugfix] fix bug where we are not running the correct number of warmu… #717

Closed lqwk closed 2 years ago

lqwk commented 2 years ago

This seems like a typo in the original code. We are running warmup runs getRuntimesPerObservationCount times where we should be actually running it getWarmupRunsPerRuntimeObservationCount times

facebook-github-bot commented 2 years ago

Hi @lqwk!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

facebook-github-bot commented 2 years ago

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

ChrisCummins commented 2 years ago

Hi @lqwk, this was clearly a bug. Thanks for the patch!

Cheers, Chris