facebookresearch / CompilerGym

Reinforcement learning environments for compiler and program optimization tasks
https://compilergym.ai/
MIT License
885 stars 123 forks source link

Fix to issue #648 #739

Closed nluu175 closed 1 year ago

nluu175 commented 1 year ago

Fixes #648

nluu175 commented 1 year ago

Hi @ChrisCummins . Thanks for the feedbacks. I'll resolve those and as soon as possible!

codecov-commenter commented 1 year ago

Codecov Report

Merging #739 (1d91115) into development (4a9f10d) will decrease coverage by 0.02%. The diff coverage is 100.00%.

Impacted file tree graph

@@               Coverage Diff               @@
##           development     #739      +/-   ##
===============================================
- Coverage        88.79%   88.77%   -0.03%     
===============================================
  Files              129      129              
  Lines             7854     7855       +1     
===============================================
- Hits              6974     6973       -1     
- Misses             880      882       +2     
Impacted Files Coverage Δ
compiler_gym/wrappers/time_limit.py 96.55% <100.00%> (+0.12%) :arrow_up:
...loop_tool/service/loop_tool_compilation_session.py 87.83% <0.00%> (-2.71%) :arrow_down:
compiler_gym/service/service_cache.py 89.47% <0.00%> (-2.64%) :arrow_down:
...ompiler_gym/service/client_service_compiler_env.py 90.23% <0.00%> (-0.22%) :arrow_down:
compiler_gym/service/connection.py 78.92% <0.00%> (+0.33%) :arrow_up:
compiler_gym/views/observation_space_spec.py 85.71% <0.00%> (+2.85%) :arrow_up:
compiler_gym/views/observation.py 100.00% <0.00%> (+3.12%) :arrow_up:
compiler_gym/util/truncate.py 96.29% <0.00%> (+3.70%) :arrow_up:
ChrisCummins commented 1 year ago

Changes LGTM, thanks! I will merge once CI tests pass.

Cheers, Chris